Skip to content

Conversation

CommandMC
Copy link
Collaborator

@CommandMC CommandMC commented Sep 12, 2025

"Use Default Wine Settings" is (1) inaccurate and (2) doesn't really convey what the option does. In my opinion it sounds too much like a positive thing you always want to turn on, while in actuality you likely don't want it enabled


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@CommandMC CommandMC requested review from a team, arielj, flavioislima, Etaash-mathamsetty, biliesilva, Nocccer and imLinguin and removed request for a team September 12, 2025 14:01
@CommandMC CommandMC self-assigned this Sep 12, 2025
@CommandMC CommandMC added the pr:ready-for-review Feature-complete, ready for the grind! :P label Sep 12, 2025
@arielj
Copy link
Collaborator

arielj commented Sep 21, 2025

linking #3274 as this covers a bit of what I proposed there

@arielj arielj merged commit 2559f3b into main Sep 21, 2025
9 checks passed
@arielj arielj deleted the mv/use-default-wine-settings branch September 21, 2025 13:43
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Sep 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants